Replace hardcoded additional_owners param with ACCOUNT_ID setup var#260
Open
hiribarne wants to merge 1 commit intoxdevplatform:masterfrom
Open
Replace hardcoded additional_owners param with ACCOUNT_ID setup var#260hiribarne wants to merge 1 commit intoxdevplatform:masterfrom
hiribarne wants to merge 1 commit intoxdevplatform:masterfrom
Conversation
|
|
osowskit
suggested changes
Aug 31, 2020
| resource = '/1.1/media/upload.json' | ||
| params = { | ||
| 'additional_owners': '756201191646691328', | ||
| 'additional_owners': ACCOUNT_ID, |
Contributor
There was a problem hiding this comment.
Great catch that this was hardcoded. This field represent the user ID of another user that should have access to use this asset. So this field is only necessary when the credentials that are uploading the asset are different from a user to an ads account that will use the asset. In this example, it isn't clear how to provide an additional_owners value that would make sense.
It might be best to comment out this parameter but add a note that this should be set for another user ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the hardcoded userid in the additional_owners parameter in this example. I think it should be the ACCOUNT_ID. Please review. Thanks